Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-history): duplicated symbol and metric prefix #969

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Sep 26, 2023

Purpose or design rationale of this PR

This PR fixes a compile error and a runtime error.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@colinlyguo colinlyguo self-assigned this Sep 26, 2023
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Sep 26, 2023
mask-pp
mask-pp previously approved these changes Sep 26, 2023
@colinlyguo colinlyguo merged commit 8f745e9 into develop Sep 26, 2023
@colinlyguo colinlyguo deleted the fix-duplicated-symbol branch September 26, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants