Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge-history): add cache hit metrics and cache non-existent keys #970

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Sep 26, 2023

Purpose or design rationale of this PR

This PR adds cache hit metrics and caches non-existent keys.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #970 (4882959) into develop (8f745e9) will not change coverage.
The diff coverage is n/a.

❗ Current head 4882959 differs from pull request most recent head 04b3e8b. Consider uploading reports for the commit 04b3e8b to get more accurate results

@@           Coverage Diff            @@
##           develop     #970   +/-   ##
========================================
  Coverage    48.10%   48.10%           
========================================
  Files          100      100           
  Lines        10562    10562           
========================================
  Hits          5081     5081           
  Misses        5060     5060           
  Partials       421      421           
Flag Coverage Δ
bridge-history-api 11.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@colinlyguo colinlyguo merged commit 35d4ec5 into develop Sep 26, 2023
@colinlyguo colinlyguo deleted the fix-bridge-history-cache-non-exsist-values branch September 26, 2023 15:43
@colinlyguo colinlyguo self-assigned this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants