Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watcher&rollup): add block commit calldata size and commit/finalize batch revert metrics #974

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Sep 29, 2023

Purpose or design rationale of this PR

This PR adds:

  1. A block commit calldata size metric in l2-watcher.
  2. Commit/finalize batch revert metrics in rollup-relayer.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@colinlyguo colinlyguo self-assigned this Sep 29, 2023
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Sep 29, 2023
@colinlyguo colinlyguo changed the title feat(l2-watcher): add block commit calldata size feat(l2-watcher): add block commit calldata size metric Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #974 (e60f31a) into develop (47e5a43) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #974      +/-   ##
===========================================
+ Coverage    48.10%   48.18%   +0.08%     
===========================================
  Files          100      100              
  Lines        10562    10579      +17     
===========================================
+ Hits          5081     5098      +17     
  Misses        5060     5060              
  Partials       421      421              
Flag Coverage Δ
rollup 66.54% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
rollup/internal/controller/relayer/l2_relayer.go 41.56% <100.00%> (+0.24%) ⬆️
.../internal/controller/relayer/l2_relayer_metrics.go 100.00% <100.00%> (ø)
rollup/internal/controller/watcher/l2_watcher.go 70.04% <100.00%> (+0.41%) ⬆️
.../internal/controller/watcher/l2_watcher_metrics.go 100.00% <100.00%> (ø)

georgehao
georgehao previously approved these changes Sep 29, 2023
@colinlyguo colinlyguo changed the title feat(l2-watcher): add block commit calldata size metric feat(watcher&rollup): add block commit calldata size and commit/finalize batch revert metrics Sep 29, 2023
@colinlyguo colinlyguo merged commit c551609 into develop Sep 29, 2023
11 checks passed
@colinlyguo colinlyguo deleted the feat-rollup-add-block-commit-calldata-size branch September 29, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants