Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chunk/batch get_task index #976

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Sep 29, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

add the missing index of chunk/batch get_task

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@georgehao georgehao requested a review from Thegaram September 29, 2023 13:03
mask-pp
mask-pp previously approved these changes Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #976 (46639a5) into develop (c551609) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #976   +/-   ##
========================================
  Coverage    48.18%   48.18%           
========================================
  Files          100      100           
  Lines        10579    10579           
========================================
  Hits          5098     5098           
  Misses        5060     5060           
  Partials       421      421           
Flag Coverage Δ
database 42.85% <ø> (ø)
rollup 66.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@georgehao georgehao merged commit 76d66eb into develop Sep 29, 2023
17 checks passed
@georgehao georgehao deleted the feat/add_chunk_batch_get_task_index branch September 29, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants