Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove DAI gateway from deployment script #979

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

Thegaram
Copy link
Contributor

@Thegaram Thegaram commented Oct 5, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

Deploying DAIGateway in the deployment scripts is error prone, since we cannot set L2_DAI_ADDRESS at this point (it's not deployed yet). It's better to let @zimpha deploy it manually.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@Thegaram Thegaram requested a review from zimpha October 5, 2023 19:22
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

LCOV of commit d4ebe90 during Contracts #96

Summary coverage rate:
  lines......: 51.4% (1005 of 1954 lines)
  functions..: 65.1% (224 of 344 functions)
  branches...: no data found

Files changed coverage rate: n/a

@Thegaram Thegaram merged commit 0cdb0dc into develop Oct 6, 2023
@Thegaram Thegaram deleted the remove-dai-gateway-deployment branch October 6, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants