-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rollup-relayer): better handle commit batch revert #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #981 +/- ##
===========================================
- Coverage 48.19% 48.14% -0.05%
===========================================
Files 100 100
Lines 10580 10590 +10
===========================================
Hits 5099 5099
- Misses 5060 5069 +9
- Partials 421 422 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thegaram
previously approved these changes
Oct 8, 2023
Thegaram
previously approved these changes
Oct 8, 2023
zimpha
reviewed
Oct 8, 2023
0xmountaintop
previously approved these changes
Oct 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nickpit
Co-authored-by: HAOYUatHZ <[email protected]>
colinlyguo
dismissed stale reviews from 0xmountaintop and Thegaram
via
October 8, 2023 09:35
27b57af
Thegaram
approved these changes
Oct 8, 2023
zimpha
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Problem:
When
rollup-relayer
encounters a batch commit failure, it continues to commit subsequent batches, which would fail.Solutions:
estimateGas
for batches that have been committed failed.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?