Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libzkp): upgrade to use prover v0.9.7 #989

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix(libzkp): upgrade to use prover v0.9.7 #989

merged 2 commits into from
Oct 13, 2023

Conversation

silathdiir
Copy link
Contributor

Purpose or design rationale of this PR

https://www.notion.so/scrollzkp/v0-9-7-e2cb21fcf6d74fa89fc18109e777ff3a

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@silathdiir silathdiir added breaking-change bump-version Bump the version tag for deployment labels Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #989 (34637ec) into develop (25d5fab) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 34637ec differs from pull request most recent head cf8efce. Consider uploading reports for the commit cf8efce to get more accurate results

@@           Coverage Diff            @@
##           develop     #989   +/-   ##
========================================
  Coverage    48.14%   48.14%           
========================================
  Files          100      100           
  Lines        10591    10591           
========================================
  Hits          5099     5099           
  Misses        5070     5070           
  Partials       422      422           
Flag Coverage Δ
common 54.94% <ø> (ø)
coordinator 18.94% <ø> (ø)
rollup 66.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@silathdiir silathdiir changed the title [WIP] fix(libzkp): upgrade to use prover v0.9.7 fix(libzkp): upgrade to use prover v0.9.7 Oct 13, 2023
@silathdiir
Copy link
Contributor Author

test_zkp could pass.

v0 9 7

@georgehao georgehao merged commit 9e8c343 into develop Oct 13, 2023
@georgehao georgehao deleted the libzkp-v0.9.7 branch October 13, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants