Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade l2geth to scroll-v5.0.1 #996

Closed
wants to merge 12 commits into from
Closed

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Oct 19, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #996 (9af3903) into develop (2102e16) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #996   +/-   ##
========================================
  Coverage    48.14%   48.14%           
========================================
  Files          100      100           
  Lines        10591    10591           
========================================
  Hits          5099     5099           
  Misses        5070     5070           
  Partials       422      422           
Flag Coverage Δ
bridge-history-api 11.12% <ø> (ø)
common 54.94% <ø> (ø)
coordinator 18.94% <ø> (ø)
database 42.85% <ø> (ø)
prover 27.32% <ø> (ø)
rollup 66.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@0xmountaintop 0xmountaintop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also better upgrade the submodule?

image

@0xmountaintop 0xmountaintop changed the title Feat/update dependence feat: upgrade l2geth to scroll-v5.0.1 Oct 20, 2023
@mask-pp
Copy link
Contributor Author

mask-pp commented Oct 20, 2023

also better upgrade the submodule?

image

L2geth's version is changed to scroll-v5.0.1.

@mask-pp mask-pp requested a review from 0xmountaintop October 20, 2023 02:11
@georgehao georgehao closed this Dec 14, 2023
@0xmountaintop 0xmountaintop deleted the feat/update_dependence branch May 7, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants