remove unused codes of sig circuit

scroll-tech · Oct 28, 2024 · 402b1c6 · 402b1c6
1 parent cd7d774
commit 402b1c6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 32 deletions.
diff --git a/zkevm-circuits/src/sig_circuit.rs b/zkevm-circuits/src/sig_circuit.rs
@@ -151,35 +151,6 @@ impl<F: Field> SubCircuitConfig<F> for SigCircuitConfig<F> {
             FpConfig::construct(range.clone(), limb_bits, num_limbs, modulus::<Fp_K1>());
         let ecdsa_r1_config = FpConfig::construct(range, limb_bits, num_limbs, modulus::<Fp_R1>());
 
-        // let ecdsa_k1_config = FpConfig::configure(
-        //     meta,
-        //     FpStrategy::Simple,
-        //     &num_advice,
-        //     &num_lookup_advice,
-        //     1,
-        //     LOG_TOTAL_NUM_ROWS - 1,
-        //     88,
-        //     3,
-        //     modulus::<Fp_K1>(),
-        //     0,
-        //     LOG_TOTAL_NUM_ROWS, // maximum k of the chip
-        // );
-
-        // // TODO: check if ecdsa_r1_config parameters need to be tuned.
-        // let ecdsa_r1_config = FpConfig::configure(
-        //     meta,
-        //     FpStrategy::Simple,
-        //     &num_advice,
-        //     &num_lookup_advice,
-        //     1,
-        //     LOG_TOTAL_NUM_ROWS - 1,
-        //     88,
-        //     3,
-        //     modulus::<Fp_R1>(),
-        //     0,
-        //     LOG_TOTAL_NUM_ROWS, // maximum k of the chip
-        // );
-
         // we need one phase 2 column to store RLC results
         #[cfg(feature = "onephase")]
         let rlc_column = meta.advice_column_in(halo2_proofs::plonk::FirstPhase);
@@ -581,8 +552,6 @@ impl<F: Field> SigCircuit<F> {
                 4,
             );
 
-        println!("sig_is_valid {:?}", sig_is_valid);
-
         // =======================================
         // constrains v == y.is_oddness()
         // =======================================

diff --git a/zkevm-circuits/src/sig_circuit/test.rs b/zkevm-circuits/src/sig_circuit/test.rs
@@ -205,7 +205,7 @@ fn sign_k1_verify() {
         log::debug!("end of testing for msg_hash = 1");
     }
     // random msg_hash
-    let max_sigs = [1, 16, MAX_NUM_SIG_K1];
+    let max_sigs = [1, 16, MAX_NUM_SIG_K1 - 1];
     for max_sig in max_sigs.iter() {
         log::debug!("testing for {} signatures", max_sig);
         let mut signatures = Vec::new();