fix degree pow of rand table in agg circuit (#1335)

* fix degree pow of rand table in agg circuit * change some log level from info to debug
scroll-tech · Jun 11, 2024 · fedf661 · fedf661
1 parent 4c4d117
commit fedf661
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/aggregator/src/aggregation/circuit.rs b/aggregator/src/aggregation/circuit.rs
@@ -1,4 +1,4 @@
-use crate::{blob::BatchData, witgen::MultiBlockProcessResult};
+use crate::{blob::BatchData, witgen::MultiBlockProcessResult, LOG_DEGREE};
 use ark_std::{end_timer, start_timer};
 use halo2_base::{Context, ContextParams};
 use halo2_proofs::{
@@ -489,7 +489,7 @@ impl<const N_SNARKS: usize> Circuit<Fr> for AggregationCircuit<N_SNARKS> {
                 address_table_arr,
                 sequence_exec_info_arr,
                 &challenges,
-                20, // TODO: configure k for aggregation circuit instead of hard-coded here.
+                LOG_DEGREE, // TODO: configure k for aggregation circuit instead of hard-coded here.
             )?;
 
             layouter.assign_region(

diff --git a/aggregator/src/core.rs b/aggregator/src/core.rs
@@ -299,7 +299,7 @@ impl<const N_SNARKS: usize> ExtractedHashCells<N_SNARKS> {
             .zip_eq(self.output_rlcs.iter())
             .enumerate()
         {
-            log::info!(
+            log::debug!(
                 "{}-th rlc {:?} {:?}",
                 i,
                 input_rlcs.value(),
@@ -714,11 +714,11 @@ pub(crate) fn conditional_constraints<const N_SNARKS: usize>(
                     &mut offset,
                 )?;
 
-                log::info!(
+                log::debug!(
                     "batch data hash rlc recomputed: {:?}",
                     batch_data_hash_rlc.value()
                 );
-                log::info!(
+                log::debug!(
                     "batch data hash rlc from table: {:?}",
                     assigned_hash_cells.output_rlcs[N_SNARKS + 1].value()
                 );
@@ -769,11 +769,11 @@ pub(crate) fn conditional_constraints<const N_SNARKS: usize>(
                     assigned_hash_cells.input_rlcs[N_SNARKS + 1].cell(),
                 )?;
 
-                log::info!(
+                log::debug!(
                     "batch data hash rlc reconstructed: {:?}",
                     batch_data_hash_reconstructed_rlc.value()
                 );
-                log::info!(
+                log::debug!(
                     "batch data hash rlc from table: {:?}",
                     assigned_hash_cells.input_rlcs[N_SNARKS + 1].value()
                 );

diff --git a/zkevm-circuits/src/table.rs b/zkevm-circuits/src/table.rs
@@ -3135,6 +3135,8 @@ impl PowOfRandTable {
                     )?;
                 }
 
+                log::debug!("assign pow of rand with rows {} done", max_rows);
+
                 Ok(())
             },
         )