Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Sync halo2 lib 0.4.0 #1008

Draft
wants to merge 34 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
75a0001
wip
zhenfeizhang Oct 27, 2023
5cfcbd7
enforce eth v2.0.7
zhenfeizhang Oct 27, 2023
d485ecc
update links
zhenfeizhang Oct 27, 2023
614f9fc
clean up zktrie
zhenfeizhang Oct 27, 2023
0672a17
fix keccak circuit
zhenfeizhang Oct 27, 2023
11d4fe6
fix gadgets
zhenfeizhang Oct 27, 2023
95774d8
fix bus-mapping
zhenfeizhang Oct 27, 2023
bae6f57
everything compiles now
zhenfeizhang Oct 30, 2023
d8124db
almost there
zhenfeizhang Oct 30, 2023
ce7a7ac
finished functions in ecdsa
zhenfeizhang Oct 30, 2023
ce985f7
workspace links
zhenfeizhang Nov 6, 2023
a6622f5
wip
zhenfeizhang Nov 6, 2023
b076e1b
wip
zhenfeizhang Nov 6, 2023
330ad9c
wip
zhenfeizhang Nov 7, 2023
254fa27
single phase constraint failure
zhenfeizhang Nov 7, 2023
9b1fc15
wip
zhenfeizhang Nov 7, 2023
1904a7c
finished ecdsa refactor
zhenfeizhang Dec 4, 2023
ba9ec9b
update links
zhenfeizhang Dec 4, 2023
ad602a0
clean up ecdsa code
zhenfeizhang Dec 12, 2023
966181f
update mock prover patch
zhenfeizhang Dec 13, 2023
94cece0
update ecdsa parameters
zhenfeizhang Dec 13, 2023
fbf753e
wip
zhenfeizhang Dec 29, 2023
751d701
clean up
zhenfeizhang Dec 29, 2023
6172f5d
more tests
zhenfeizhang Dec 29, 2023
7cc81c3
wip
zhenfeizhang Dec 30, 2023
8dd2962
wip
zhenfeizhang Jan 1, 2024
5b90206
refactor aggregation
zhenfeizhang Jan 1, 2024
37a8f0d
fixed two pass assignment
zhenfeizhang Jan 1, 2024
6dcda9f
wip
zhenfeizhang Jan 1, 2024
fec4e05
fix pi hashes
zhenfeizhang Jan 1, 2024
1d40acf
everything works now
zhenfeizhang Jan 1, 2024
53d7a97
clean up
zhenfeizhang Jan 1, 2024
525acc1
clean up and re-enable tests
zhenfeizhang Jan 1, 2024
0af26d6
minor clean up
zhenfeizhang Jan 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,835 changes: 1,179 additions & 656 deletions Cargo.lock

Large diffs are not rendered by default.

33 changes: 21 additions & 12 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,14 @@ ctor = "0.1"
env_logger = "0.10"
ethers = { version = "2.0.7", features = ["ethers-solc"] }
ethers-core = { git = "https://github.com/scroll-tech/ethers-rs.git", branch = "v2.0.7", features = ["scroll"] }
ethers-providers = "2.0.7"
ethers-signers = "2.0.7"
halo2_proofs = { git = "https://github.com/scroll-tech/halo2.git", branch = "develop" }
hash-circuit = { package = "poseidon-circuit", git = "https://github.com/scroll-tech/poseidon-circuit.git", branch = "scroll-dev-0901"}
ethers-providers = "=2.0.7"
ethers-signers = "=2.0.7"
halo2_proofs = { git = "https://github.com/scroll-tech/halo2.git", branch = "sync-halo2-lib-0.4.0" }
hash-circuit = { package = "poseidon-circuit", git = "https://github.com/scroll-tech/poseidon-circuit.git", branch = "sync-halo2-lib-0.4.0" }
halo2-base = { git = "https://github.com/scroll-tech/halo2-lib", branch = "sync-halo2-lib-0.4.0", default-features=false, features=["halo2-pse","display","test-utils"] }
halo2-ecc = { git = "https://github.com/scroll-tech/halo2-lib", branch = "sync-halo2-lib-0.4.0", default-features=false, features=["halo2-pse","display"] }
# halo2-base = { path = "../halo2-lib/halo2-base", default-features=false, features=["halo2-pse","display","test-utils"] }
# halo2-ecc = { path = "../halo2-lib/halo2-ecc", default-features=false, features=["halo2-pse","display"] }
hex = "0.4"
itertools = "0.10"
lazy_static = "1.4"
Expand All @@ -50,8 +54,11 @@ regex = "1.5"
serde = {version = "1.0", features = ["derive"] }
serde_json = "1.0"
sha3 = "0.10"
snark-verifier = { git = "https://github.com/scroll-tech/snark-verifier", tag = "v0.1.5" }
snark-verifier-sdk = { git = "https://github.com/scroll-tech/snark-verifier", tag = "v0.1.5", default-features = false, features = ["loader_halo2", "loader_evm", "halo2-pse"] }
snark-verifier = { git = "https://github.com/scroll-tech/snark-verifier", branch = "sync-halo2-lib-0.4.0" }
snark-verifier-sdk = { git = "https://github.com/scroll-tech/snark-verifier", branch = "sync-halo2-lib-0.4.0", default-features = false, features = ["loader_halo2", "loader_evm", "halo2-pse"] }
# snark-verifier = { path = "../snark-verifier/snark-verifier" }
# snark-verifier-sdk = { path = "../snark-verifier/snark-verifier-sdk", default-features = false, features = ["loader_halo2", "loader_evm", "halo2-pse"] }

strum = "0.24"
strum_macros = "0.24"
subtle = "2.4"
Expand All @@ -62,13 +69,15 @@ url = "2.2"
ethers-core = { git = "https://github.com/scroll-tech/ethers-rs.git", branch = "v2.0.7" }
ethers-etherscan = { git = "https://github.com/scroll-tech/ethers-rs.git", branch = "v2.0.7" }
[patch."https://github.com/privacy-scaling-explorations/halo2.git"]
halo2_proofs = { git = "https://github.com/scroll-tech/halo2.git", branch = "develop" }
# halo2_proofs = { path = "../halo2/halo2_proofs" }
halo2_proofs = { git = "https://github.com/scroll-tech/halo2.git", branch = "sync-halo2-lib-0.4.0" }
# [patch."https://github.com/scroll-tech/halo2.git"]
# halo2_proofs = { path = "../halo2/halo2_proofs" }
[patch."https://github.com/privacy-scaling-explorations/poseidon.git"]
poseidon = { git = "https://github.com/scroll-tech/poseidon.git", branch = "scroll-dev-0220" }
[patch."https://github.com/privacy-scaling-explorations/halo2curves.git"]
halo2curves = { git = "https://github.com/scroll-tech/halo2curves.git", branch = "0.3.1-derive-serde" }
[patch."https://github.com/privacy-scaling-explorations/halo2wrong.git"]
maingate = { git = "https://github.com/scroll-tech/halo2wrong", branch = "halo2-ecc-snark-verifier-0323" }
poseidon = { git = "https://github.com/scroll-tech/poseidon.git", branch = "sync-halo2-lib-0.4.0" }
# [patch."https://github.com/privacy-scaling-explorations/halo2wrong.git"]
# maingate = { git = "https://github.com/scroll-tech/halo2wrong", branch = "halo2-ecc-snark-verifier-0323" }


# Definition of benchmarks profile to use.
[profile.bench]
Expand Down
4 changes: 3 additions & 1 deletion aggregator/src/aggregation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ mod circuit;
mod config;
/// config for RLC circuit
mod rlc;
/// utilities
mod util;

pub use circuit::AggregationCircuit;
pub use config::AggregationConfig;
pub(crate) use rlc::RlcConfig;
pub use rlc::RlcConfig;
Loading