Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Small updates exec_trace.rs #1106

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nikolala13
Copy link

@nikolala13 nikolala13 commented Feb 14, 2024

Description

Github Repo

https://github.com/nikolala13/zkevm-circuits

[PR description]

Issue Link

[link issue here]

Type of change

  • Instead of writing 'f.write_fmt(format_args!(...))', you can use the method 'write!'
  • I would also add comments to each Target option explaining their meaning

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

1. Instead of writing 'f.write_fmt(format_args!(...))', you can use the method 'write!'
2. I would also add comments to each Target option explaining their meaning
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant