Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

word stage3: try remove rlc related #1112

Open
wants to merge 12 commits into
base: word_hi_lo
Choose a base branch
from
Open

word stage3: try remove rlc related #1112

wants to merge 12 commits into from

Conversation

DreamWuGit
Copy link

@DreamWuGit DreamWuGit commented Feb 21, 2024 •
edited
Loading

Description

keccak circuit

  • remove output_rlc field

evm circuit

  • begin_tx: remove corresponding output_rlc
  • sha3: remove corresponding output_rlc
  • create: remove corresponding output_rlc
  • blockhash: remove corresponding output_rlc

bytecode circuit

  • remove keccak lookup rlc
  • todo

tx circuit

  • remove rlc in keccak lookup
  • todo

pi circuit

  • remove rlc output in keccak lookup
  • todo

sig circuit

  • todo
  • todo

aggregation circuit

  • fix test_aggregation_circuit & test_hash_circuit， pass now
  • todo

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

@DreamWuGit DreamWuGit marked this pull request as ready for review February 26, 2024 09:06
@DreamWuGit
Copy link
Author

DreamWuGit commented Feb 26, 2024 •
edited
Loading

make ready just for ci testing purpose at the moment..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crate-zkevm-circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DreamWuGit