Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update L1 data fee for curie #1293

Merged
merged 40 commits into from
May 30, 2024
Merged

update L1 data fee for curie #1293

merged 40 commits into from
May 30, 2024

Conversation

DreamWuGit
Copy link
Member

@DreamWuGit DreamWuGit commented May 27, 2024 •
edited
Loading

Description

  • add feature l1_fee_curie switch for curie fork
  • buss mapping update transaction to get new fields
  • update circuit(L1fee gadget) for new fields operations and apply new formula
    • begin_tx
    • end_tx
    • TxL1FeeGadget
  • testing stuffs

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@DreamWuGit
Copy link
Member Author

mark ready for ci checking purpose

@DreamWuGit DreamWuGit marked this pull request as ready for review May 28, 2024 09:25
lispc
lispc reviewed May 29, 2024
View reviewed changes
zkevm-circuits/src/evm_circuit/util/common_gadget/tx_l1_fee.rs
/// Committed value of L1 base fee
#[cfg(feature = "l1_fee_curie")]
/// Current value of L1 blob base fee
l1_blob_basefee_word: U64Word<F>,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check with peter whether they really in range u64.

@lispc
Copy link

lispc commented May 29, 2024

if scroll-prover test passes, i will merge this. But later i think we should add some unit tests in repo.

lispc
lispc reviewed May 29, 2024
View reviewed changes
eth-types/src/geth_types.rs Outdated Show resolved Hide resolved
@DreamWuGit
Copy link
Member Author

if scroll-prover test passes, i will merge this. But later i think we should add some unit tests in repo.

wow, test have passed!!

@lispc lispc marked this pull request as ready for review May 29, 2024 14:26
@DreamWuGit DreamWuGit mentioned this pull request May 30, 2024
Closed
DreamWuGit and others added 4 commits May 30, 2024 09:57
@DreamWuGit
update link
43e1200
@DreamWuGit
try eth_tx.rlp
5e0d566
@DreamWuGit
remove get_rlp_signed
ec016bd
@noel2004 @DreamWuGit
[FIX #1307] (#1308)
deb6d5c 
* fix constraint for remainder in l1fee

Signed-off-by: noelwei <[email protected]>

* fmt

Signed-off-by: noelwei <[email protected]>

---------

Signed-off-by: noelwei <[email protected]>
Co-authored-by: DreamWuGit <[email protected]>
@lispc lispc merged commit 6368e07 into develop May 30, 2024
15 checks passed
@lispc lispc deleted the l1fee_curie branch May 30, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noel2004 noel2004 noel2004 left review comments

@lispc lispc lispc left review comments

@kunxian-xia kunxian-xia kunxian-xia left review comments

Assignees
No one assigned
Labels
crate-bus-mapping crate-eth-types crate-geth-utils crate-zkevm-circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DreamWuGit @lispc @kunxian-xia @noel2004