Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA-Compression soundness tests #1385

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

roynalnaruto
Copy link

@roynalnaruto roynalnaruto commented Jul 30, 2024

Overview

We add a feature soundness-tests where we return an Assigned* type from the tables post-witness assignment. In the tests enabled by the soundness-tests feature, we mutate these assigned cells to trigger malicious scenarios and expect the constraints for those tables to not be satisfied.

noel2004 and others added 3 commits July 30, 2024 01:25
* more verification on positive tests

Signed-off-by: noelwei <[email protected]>

* prerequisite for negative tests

Signed-off-by: noelwei <[email protected]>

* negative mock framework for inst table

Signed-off-by: noelwei <[email protected]>

* negative sample

Signed-off-by: noelwei <[email protected]>

* more negative samples

Signed-off-by: noelwei <[email protected]>

* extend testing framework

Signed-off-by: noelwei <[email protected]>

* negative test framework

Signed-off-by: noelwei <[email protected]>

* negative tests

Signed-off-by: noelwei <[email protected]>

* more negative tests

Signed-off-by: noelwei <[email protected]>

* more negative tests

Signed-off-by: noelwei <[email protected]>

* more negative tests

Signed-off-by: noelwei <[email protected]>

---------

Signed-off-by: noelwei <[email protected]>
* Add skeleton for bitstring soundness tests

* Add test skeleton

* Add test case

* Add test cases

* Complete bitstring table test cases

* Fix compilation

* Adjust feature flag

* fmt and clippy

* Complete debugging test cases

* fmt

* Fix failing constraint from non feature flag

---------

Co-authored-by: Rohit Narurkar <[email protected]>
* Add literals header soundness tests

* fmt

* Compilation Fix

* Clippy

* fmt

* fmt

* Use multiblock test vector for literal table soundness tests

* Remove debug flags

* Add feature flag

* Debug tests

* Fix feature flag test failure

---------

Co-authored-by: Rohit Narurkar <[email protected]>
@roynalnaruto roynalnaruto added the da-compression Support compression of L2 data made available on L1 label Jul 30, 2024
@lispc
Copy link

lispc commented Aug 29, 2024

what is missing here? still draft?

@roynalnaruto
Copy link
Author

@lispc This PR itself is ready-for-review. The PR that has not been finished is this: #1305

I think we can get this PR merged and then work on FSE table soundness tests.

@roynalnaruto roynalnaruto marked this pull request as ready for review August 29, 2024 10:20
@roynalnaruto roynalnaruto requested a review from lispc August 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
da-compression Support compression of L2 data made available on L1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants