forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DA-Compression soundness tests #1385
Open
roynalnaruto
wants to merge
7
commits into
develop
Choose a base branch
from
tests/da-compression-soundness
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* more verification on positive tests Signed-off-by: noelwei <[email protected]> * prerequisite for negative tests Signed-off-by: noelwei <[email protected]> * negative mock framework for inst table Signed-off-by: noelwei <[email protected]> * negative sample Signed-off-by: noelwei <[email protected]> * more negative samples Signed-off-by: noelwei <[email protected]> * extend testing framework Signed-off-by: noelwei <[email protected]> * negative test framework Signed-off-by: noelwei <[email protected]> * negative tests Signed-off-by: noelwei <[email protected]> * more negative tests Signed-off-by: noelwei <[email protected]> * more negative tests Signed-off-by: noelwei <[email protected]> * more negative tests Signed-off-by: noelwei <[email protected]> --------- Signed-off-by: noelwei <[email protected]>
* Add skeleton for bitstring soundness tests * Add test skeleton * Add test case * Add test cases * Complete bitstring table test cases * Fix compilation * Adjust feature flag * fmt and clippy * Complete debugging test cases * fmt * Fix failing constraint from non feature flag --------- Co-authored-by: Rohit Narurkar <[email protected]>
* Add literals header soundness tests * fmt * Compilation Fix * Clippy * fmt * fmt * Use multiblock test vector for literal table soundness tests * Remove debug flags * Add feature flag * Debug tests * Fix feature flag test failure --------- Co-authored-by: Rohit Narurkar <[email protected]>
roynalnaruto
added
the
da-compression
Support compression of L2 data made available on L1
label
Jul 30, 2024
what is missing here? still draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We add a feature
soundness-tests
where we return anAssigned*
type from the tables post-witness assignment. In the tests enabled by thesoundness-tests
feature, we mutate these assigned cells to trigger malicious scenarios and expect the constraints for those tables to not be satisfied.