(v0.12.2) Move params out of prover/verifier #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispc
commented
Aug 26, 2024
13 tasks
roynalnaruto
approved these changes
Aug 26, 2024
prover/src/aggregator/prover.rs
Outdated
| impl Prover { | ||
| pub fn from_dirs(params_dir: &str, assets_dir: &str) -> Self { | ||
| impl<'params> Prover<'params> { | ||
| pub fn degrees() -> Vec<u32> { |
There was a problem hiding this comment.
we don't need this degrees method in both the aggregetor/zkevm verifier, since we don't use it. The degrees needed to instantiate the Prover are more than the degrees needed to instantiate the Verifier (which is used by libzkp). Since that part is already handled by simply the layer2_degree and layer4_degree, we don't need to expose another function degrees() here. So I am removing it.
roynalnaruto
changed the title
roynalnaruto
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Looks good. Added sanity check in commit: 339fe40
Commented on wrong PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same with #1405
to update, we need to first push to this branch, then merge into v0.13