Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-eip155 evm circuit test #1412

Merged
merged 19 commits into from
Sep 18, 2024
Merged

add pre-eip155 evm circuit test #1412

merged 19 commits into from
Sep 18, 2024

Conversation

DreamWuGit
Copy link
Member

@DreamWuGit DreamWuGit commented Aug 29, 2024

Description

currently eve circuit lacks pre-eip155 type test, add in this PR and related changes

  • get_utils trace support pre-eip155 type tx
  • add two tests in begin_tx testing
  • adapt MockTransaction to tx with entire signature data.

@DreamWuGit DreamWuGit changed the title Don't merge: add pre-eip155 evm circuit test WIP: add pre-eip155 evm circuit test Sep 6, 2024
@DreamWuGit DreamWuGit marked this pull request as ready for review September 11, 2024 03:30
@DreamWuGit DreamWuGit changed the title WIP: add pre-eip155 evm circuit test add pre-eip155 evm circuit test Sep 11, 2024
geth-utils/l2geth/trace.go Outdated Show resolved Hide resolved
mock/src/transaction.rs Outdated Show resolved Hide resolved
@lispc
Copy link

lispc commented Sep 12, 2024

leave some small comments

@lispc lispc merged commit 5ee0157 into develop Sep 18, 2024
17 checks passed
@lispc lispc deleted the pre-eip155 branch September 18, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants