Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Rust toolchain #1418

Merged
merged 10 commits into from
Sep 12, 2024
Merged

upgrade Rust toolchain #1418

merged 10 commits into from
Sep 12, 2024

Conversation

lispc
Copy link

@lispc lispc commented Sep 10, 2024

No description provided.

@lightsing lightsing marked this pull request as ready for review September 10, 2024 07:23
@roynalnaruto
Copy link

@lispc @lightsing can we switch back to the older commit for snark-verifier and snark-verifier-sdk, i.e. https://github.com/scroll-tech/snark-verifier/tree/58c46b74c73156b9e09dc27617369d2acfb4461b

The tests here are failing because the dependency on snark-verifier got updated to develop HEAD and that includes a commit that uses features = ["circuit-params"]. This change was originally meant for the snark-verifier+halo2 upgrade.

@lispc
Copy link
Author

lispc commented Sep 10, 2024

When we will Merge compression circuit snark upgrade pr? If it will happen in 1-2 days, in this pr let us just manually edit Cargo lock?

Or revert the last Cargo update commit?

@roynalnaruto
Copy link

can we switch back to the older commit for snark-verifier

Or instead, its better to keep this new version dependency, and fix the tests (add the Params field for various circuits).

@roynalnaruto roynalnaruto changed the title wip Chore/upgrade rust upgrade Rust toolchain Sep 10, 2024
@lispc lispc merged commit e3f8cc1 into develop Sep 12, 2024
17 checks passed
@lispc lispc deleted the chore/upgrade-rust branch September 12, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants