Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full blob test #1423

Merged
merged 7 commits into from
Sep 18, 2024
Merged

full blob test #1423

merged 7 commits into from
Sep 18, 2024

Conversation

DreamWuGit
Copy link
Member

@DreamWuGit DreamWuGit commented Sep 13, 2024 •
edited
Loading

Description

  1. modify batch274.hex in order to generate exact full blob data(N_BLOB_BYTES - 1), 1 mean first byte enable_encoding flag
  2. update and enable test

Issue Link

#1410

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@DreamWuGit DreamWuGit changed the title WIP : full blob test full blob test Sep 18, 2024
@DreamWuGit DreamWuGit marked this pull request as ready for review September 18, 2024 08:39
roynalnaruto
roynalnaruto approved these changes Sep 18, 2024
View reviewed changes
Copy link

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@roynalnaruto roynalnaruto merged commit 2879c23 into develop Sep 18, 2024
32 checks passed
@roynalnaruto roynalnaruto deleted the blob_test branch September 18, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roynalnaruto roynalnaruto roynalnaruto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DreamWuGit @roynalnaruto