This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Scroll dev 1115 #222
Closed
Scroll dev 1115 #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add log error when returndata.len() != value from RETURNDATASIZE * Update return data correctly * Add rw writes for restoring context in CREATE(2) * Fix most tests * Fix final test * Set max_rws = 0 to unbreak common-rs Co-authored-by: Mason Liang <[email protected]>
This reverts commit d88e35e.
DreamWuGit
reviewed
Dec 1, 2022
| Ok(w) => format!("{:?}", w), | ||
| Err(_) => "".to_string(), | ||
| } | ||
| } else if geth_step.op.is_call6() { |
There was a problem hiding this comment.
oh, is_call6 and is_call7 means pop 6 or 7 item from stack after think a while , rename to is_call_callcode is_static_delegate_call seems better reading
DreamWuGit
reviewed
Dec 1, 2022
| @@ -100,6 +100,17 @@ impl<P: JsonRpcClient> GethClient<P> { | |||
| .await | |||
| .map_err(|e| Error::JSONRpcError(e.into())) | |||
| } | |||
| /// .. | |||
| pub async fn get_tx_by_hash(&self, hash: H256) -> Result<Transaction, Error> { | |||
There was a problem hiding this comment.
this rpc call targets on L2geth node right ?
There was a problem hiding this comment.
both l1 and l2 work. This rpc is intended to be used to mock prove single tx.
DreamWuGit
reviewed
Dec 1, 2022
| // if overflows this opcode would fails current context, so | ||
| // there is no more steps. | ||
| if !(geth_steps.len() == 1 || geth_steps[1].depth != geth_steps[0].depth) { | ||
| log::warn!("read return data overflow, step {:?}", geth_steps[0]); |
There was a problem hiding this comment.
seems ErrReturnDataOutOfBounds we will handle in the future.
…o scroll-dev-1115
…ts into scroll-dev-1115
…ts into scroll-dev-1115
|
close in favor of #229 |
lispc
force-pushed
the
scroll-dev-1115
branch
from
7078d97 to
d3a8270
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: