OIDC support #3743
Closed
OIDC support #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: oidc 2 feat: oidc
…ing of reverse proxies.
* feat: select default seriesType for anime Added flexibility to set default anime series type in service settings. Now you can choose 'standard' for anime if you prefer it, making it easier to use features like searching for season packs on Sonarr. fix sct#3626 * feat: extracted translations
* feat: added a standard series type selector * fix: moved series type property to correct interface
Co-authored-by: Danshil Kokil Mungur <[email protected]>
Co-authored-by: Danshil Kokil Mungur <[email protected]>
* update session cookie samesite policy to lax * set cookie samesite policy based on csrf protection setting
* docs: update README.md * docs: update .all-contributorsrc --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
deleting it for PR back to mainline
lenaxia
requested review from
sct,
TheCatLady,
danshilm,
OwsleyJr and
samwiseg0
as code owners
|
Would love to review this but there is something really weird going on with the commit history here? Can we fix that? it should be rebased on develop so we are only seeing your new changes overlayed on the current head. |
|
OK. I'll see about getting that done this weekend.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Ryan Cohen - notifications at github.com ***@***.***>
Sent: Tuesday, January 9, 2024 6:21:58 PM
To: sct/overseerr - overseerr at noreply.github.com ***@***.***>
Cc: lenaxia ***@***.***>; Author - author at noreply.github.com ***@***.***>
Subject: Re: [sct/overseerr] OIDC support (PR #3743)
Would love to review this but there is something really weird going on with the commit history here? Can we fix that? it should be rebased on develop so we are only seeing your new changes overlayed on the current head.
—
Reply to this email directly, view it on GitHub<#3743 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQHNLRKSPGJMT6OFJOXG7LYNX3MNAVCNFSM6AAAAABBTROHMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBUGA4DMMRZGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rebases the oidc changes to the current Overseerr mainline (develop), and fixes some improper OIDC implementation. Because of this, it now works with authelia. Changes have also been revalidated to work with a basic configuration of Authentik. I have not tested this with other OIDC providers.
I will open a new PR to sct/overseerr if we don't merge here.
Fixes include:
aud(audience) callback parameter being an array. the OIDC spec allowsaudto be either a string, or an array of strings. Previous implementation here only allowed string when doing a oidc validation. This is now fixed to support both string and arrayinfoif LOG_LEVEL env variable is not defined (previously was debug)Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed