refactor(statusbadgemini): improve visibility of the title card status indicator #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cator on the title cards The small circle indicator was a bit difficult to see IMO. Putting a triangle that covers the upper-right of the card makes it easier to understand at a glance what the status for that movie or series is. Just a style suggestion, no hurt feelings if you don't like it :)
bobziroll
requested review from
sct,
TheCatLady,
danshilm and
OwsleyJr
as code owners
|
This is my first time contributing code to OSS (beyond just docs fixes), so please let me know if there's something I missed 🙏 |
|
Nice one @bobziroll! Seeing simple and very nice PRs like this sit for over 2 months leaves me concerned about the maintenance of this project though. |
|
I don't see us changing to this if I'm being completely honest. We appreciate the input though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The small circle indicator was a bit difficult to see IMO. Putting a triangle that covers the upper-right of the card makes it easier to understand at a glance what the status for that movie or series is.
Just a style suggestion, no hurt feelings if you don't like it :)
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed