feat(plex-login): use application name for plex product name on login #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanjones98
requested review from
sct,
TheCatLady,
danshilm and
OwsleyJr
as code owners
|
The application title should probably just completely replace the default title of "Overseerr", without the dash. This is how we do it throughout the rest of the app. |
onedr0p
reviewed
Sep 29, 2024
Comment on lines
+33
to
+35
| const authToken = await plexOAuth.login( | ||
| settings.currentSettings.applicationTitle | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const authToken = await plexOAuth.login( | |
| settings.currentSettings.applicationTitle | |
| ); | |
| const authToken = await plexOAuth.login( | |
| settings.currentSettings.applicationTitle || 'Overseerr' | |
| ); |
| @@ -40,8 +40,11 @@ class PlexOAuth { | |||
| private popup?: Window; | |||
|
|
|||
| private authToken?: string; | |||
| private DEFAULT_APPLICATION_NAME = 'Overseerr'; | |||
There was a problem hiding this comment.
Suggested change
| private DEFAULT_APPLICATION_NAME = 'Overseerr'; |
Comment on lines
+45
to
+47
| public initializeHeaders( | ||
| applicationName = this.DEFAULT_APPLICATION_NAME | ||
| ): void { |
There was a problem hiding this comment.
Suggested change
| public initializeHeaders( | |
| applicationName = this.DEFAULT_APPLICATION_NAME | |
| ): void { | |
| public initializeHeaders(applicationName): void { |
Comment on lines
+61
to
+65
| const plexProductName = | ||
| applicationName === this.DEFAULT_APPLICATION_NAME | ||
| ? applicationName | ||
| : `${applicationName} - ${this.DEFAULT_APPLICATION_NAME}`; | ||
|
|
There was a problem hiding this comment.
Suggested change
| const plexProductName = | |
| applicationName === this.DEFAULT_APPLICATION_NAME | |
| ? applicationName | |
| : `${applicationName} - ${this.DEFAULT_APPLICATION_NAME}`; |
| const browser = Bowser.getParser(window.navigator.userAgent); | ||
| this.plexHeaders = { | ||
| Accept: 'application/json', | ||
| 'X-Plex-Product': 'Overseerr', | ||
| 'X-Plex-Product': plexProductName, |
There was a problem hiding this comment.
Suggested change
| 'X-Plex-Product': plexProductName, | |
| 'X-Plex-Product': applicationName, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Plex OAuth flow to include the application name. This allows for a tad more customization and authenticating users not being concerned about what "Overseerr" is. The plex product name shows on the plex login screen as shown in the screenshots below.
If the application name is the default
Overseerrthe plex product name will beOverseerrIf the application name is not the default it will be
${applicationName} - Overseerr.Screenshot (if UI-related)
Default name of
OverseerrApplication name of
My ServerTo-Dos
yarn buildyarn i18n:extract