-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lang config for Bulgarian, Finnish, Ukrainian, Indonesian, Slovak, Turkish and Maori #3834
Conversation
Just a a small detail - #3765 is about Slovenian language (language code |
Thank you for the PR again! That would leave the languages with the codes 'bg' (Bulgarian), 'fi' (Finnish), 'he' (Hebrew), 'hi' (Hindi), 'ro' (Romanian) and 'uk' (Ukrainian) to be added. |
@danshilm stuff came up, this is later than I wanted, but those langs are removed! |
case 'uk': | ||
return import('../i18n/locale/uk.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you removed Bulgarian and Finnish from the list?
And I think when removing the languages, you didn't notice that Hebrew (hi), Hindi (hi), Romanian (ro) are already available from Weblate after #3597 had been merged. Please add those 3 back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been busy, but I got all of this sorted out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
…sian, Slovak, Turkish and Maori (sct#3834)
Description
Add config for Bulgarian, Finnish, Ukrainian, Indonesian, Turkish, Slovak and Maori
Indonesian, Turkish, Slovak and Maori need to be added to weblate.
NOTE: this PR will not build until #3597 is merged. This PR references files that are created in that PR. Once that PR is merged into develop this one can have develop merged into it, be tested locally, and it will pass.
Screenshot (if UI-related)
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed