Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lang config for Bulgarian, Finnish, Ukrainian, Indonesian, Slovak, Turkish and Maori #3834

Merged
merged 6 commits into from
May 2, 2024

Conversation

jordanjones98
Copy link
Contributor

@jordanjones98 jordanjones98 commented Apr 2, 2024

Description

Add config for Bulgarian, Finnish, Ukrainian, Indonesian, Turkish, Slovak and Maori

Indonesian, Turkish, Slovak and Maori need to be added to weblate.

NOTE: this PR will not build until #3597 is merged. This PR references files that are created in that PR. Once that PR is merged into develop this one can have develop merged into it, be tested locally, and it will pass.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@jordanjones98 jordanjones98 changed the title feat(lang): add config for finnish, bulgarian and ukranian add lang config for Bulgarian, Finnish, Ukrainian, Indonesian, Slovak, Turkish and Maori Apr 2, 2024
@avidenic
Copy link

avidenic commented Apr 3, 2024

Just a a small detail - #3765 is about Slovenian language (language code sl) but this PR is about Slovak (language code sk) so it should probably not be linked here.

@danshilm
Copy link
Collaborator

danshilm commented Apr 4, 2024

Thank you for the PR again!
The weblate PR has been merged, so I was looking into merging this but I see that you added files for the languages that don't exist on weblate yet. Can we remove those languages to allow weblate itself to create the files in the PR it will eventually make when the languages are added there to be translated? It would be pretty weird for a user to select a language only for them to see nothing translated in that language.

That would leave the languages with the codes 'bg' (Bulgarian), 'fi' (Finnish), 'he' (Hebrew), 'hi' (Hindi), 'ro' (Romanian) and 'uk' (Ukrainian) to be added.

@jordanjones98
Copy link
Contributor Author

@avidenic good catch, thank you for that, per @danshilm I am probably just going to remove the extra languages here for now. I will get this done tonight.

@jordanjones98
Copy link
Contributor Author

@danshilm stuff came up, this is later than I wanted, but those langs are removed!

Comment on lines +75 to +76
case 'uk':
return import('../i18n/locale/uk.json');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you removed Bulgarian and Finnish from the list?
And I think when removing the languages, you didn't notice that Hebrew (hi), Hindi (hi), Romanian (ro) are already available from Weblate after #3597 had been merged. Please add those 3 back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been busy, but I got all of this sorted out.

Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@sct sct merged commit b6fe5ac into sct:develop May 2, 2024
6 checks passed
Feramance pushed a commit to Feramance/overseerr that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants