Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search box for users #3947

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Search box for users #3947

wants to merge 13 commits into from

Conversation

kage1414
Copy link

@kage1414 kage1414 commented Oct 6, 2024

Description

Adds search box to users page. Searches users by username and email via database query

Screenshot (if UI-related)

Screenshot 2024-10-05 203538

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

kage1414 added 12 commits August 17, 2024 11:45
@kage1414
feat: added user search field (sct#3771)
e72e14b
@kage1414
feat: add search query (sct#3771)
52e8a2c
@kage1414
feat: search from db (sct#3771)
f51a5fb
@kage1414
refactor(userlist): cleanup request payload and BE handling
9aff74e
@kage1414
refactor(user list): move user list back to one component
8e65598 
3771
@kage1414
refactor(loading indicator): show loading indicator if no data and if…
c720ffe 
… loading

3771
@kage1414
style(search bar width): cleanup excess containers. adjust width
037ee45 
removes extra containers surrounding search bar. Limits width to 25%

3771
@kage1414
style(search bar dimensions): cleans up styling on user search bar
34829fe
@kage1414
fix(loading state & url encode): only show loading indicator if data …
776f14b 
…undefined AND isLoading

Shows empty list if data is undefined. Should not show loading if not loading
@kage1414
feat(update i18n): adds placeholder to i18n
52729b6
@kage1414
refactor(user list): add custom hook for fetching users
945a178 
3771
@kage1414
Merge branch 'develop' into search-box-for-users
a1df4a2
@kage1414 kage1414 marked this pull request as ready for review October 6, 2024 00:38
@kage1414
Copy link
Author

kage1414 commented Oct 6, 2024 •
edited
Loading

There is still one issue where the table re-renders upon search input despite results not changing. Two paths I see, we could remove querying the database and just filter on the frontend (we would need to remove backend pagination), or restructure the frontend components. Thoughts / how big of an issue is this? My vote is for restructuring components (maybe as a cleanup issue for later)

@kage1414
Copy link
Author

@sct @TheCatLady @danshilm @OwsleyJr Tagging for visibility. Could I get a review here?

@kage1414
test(userlist): remove wait for user call
7658dae 
Fetching behavior changed, remove waiting for user call and rely on wait(1000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct Awaiting requested review from sct sct is a code owner

@TheCatLady TheCatLady Awaiting requested review from TheCatLady TheCatLady is a code owner

@danshilm danshilm Awaiting requested review from danshilm danshilm is a code owner

@OwsleyJr OwsleyJr Awaiting requested review from OwsleyJr OwsleyJr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search box for users
1 participant
@kage1414