Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dim reduc #162

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Dim reduc #162

wants to merge 10 commits into from

Conversation

bschilder
Copy link
Collaborator

@bschilder bschilder commented Dec 5, 2023 •
edited
Loading

  • PR Dim reduc #162: Add dedicated internal functions for convert to/from Seurat DimReduc object.
    • Fix unit tests for Seurat converter.
    • Add missing extra final line to DESCRIPTION.
    • Make naming conventions consistent for internal functions:
      • .toseurat_check_obsvar_names --> .to_Seurat_check_obsvar_names
    • Add helper internal function: .format_Seurat_layer_key

rcannood
rcannood requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run styler::style_pkg() to apply some basic formatting?

Then, could you run lintr::lint_package() to see if it still comes up with any issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bschilder @rcannood