Utility function to list available Ensembl versions for species #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 95.65% 91.07% -4.59%
==========================================
Files 4 4
Lines 23 56 +33
==========================================
+ Hits 22 51 +29
- Misses 1 5 +4
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ivirshup
reviewed
Apr 27, 2023
Comment on lines
90
to
97
| version_table = version_table[ | ||
| version_table["rdatapath"].str.contains(f"EnsDb.{species}.v") | ||
| ] | ||
| # check that species exists | ||
| if version_table.shape[0] == 0: | ||
| raise ValueError( | ||
| f"No Ensembl database found for {species}. Check species name." | ||
| ) |
There was a problem hiding this comment.
It would be nice to get a list of available species as well. We could remove filtering by species and just return the full table?
Co-authored-by: Isaac Virshup <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17 and #16