re-enable showing circles as points #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
CIRCLES_AS_POINTSis used to determine if circles should be rendered as points (faster but viz problem when zooming in), or ellipses (precise at any zoom level but much slower).This small PR fixes a bug that occurred when
CIRCLES_AS_POINTSwas set toFalseand also let the user change this setting by moving that variable, which before was hardcoded, to a global variable.This PR also fixes a bug with the variable
POINT_SIZE_SCATTERPLOT_WIDGET, which was declared but not used.