fix plot categorical with colors, on labels #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When plotting a categorical obs column on labels, for which colors were present in the anndata, an error occurred. This was because the variable
color_dict
, which should be adict
, was an array of hex strings instead.This part of the code is not covered by tests; we should have tests like in spatialdata-plot, but since we are going to work on visualization interoperability, it makes sense to wait and have a more general way to test the same plots across all the viewers without having to manually duplicate the code and maintain redundant tests. CC @melonora