Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plot categorical with colors, on labels #337

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

LucaMarconato
Copy link
Member

When plotting a categorical obs column on labels, for which colors were present in the anndata, an error occurred. This was because the variable color_dict, which should be a dict, was an array of hex strings instead.

This part of the code is not covered by tests; we should have tests like in spatialdata-plot, but since we are going to work on visualization interoperability, it makes sense to wait and have a more general way to test the same plots across all the viewers without having to manually duplicate the code and maintain redundant tests. CC @melonora

@LucaMarconato LucaMarconato merged commit 271d4bd into main Dec 26, 2024
0 of 2 checks passed
@LucaMarconato LucaMarconato deleted the fix/categorical_labels branch December 26, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant