Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit #109

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Fix pre-commit #109

merged 2 commits into from
Aug 22, 2023

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Aug 22, 2023

Using prettier 3 helps once we know how to get it to run. There’s two issues I encountered:

  1. The way pre-commit installs it means that prettier 3 can’t find plugins anymore when they are specified in a declarative config file as string (I assume Global plugins cannot be found prettier/prettier#15141)
  2. The advertised ESM support in prettier 3 doesn’t work (Cannot use import in prettier.config.js with Prettier v3 and ESM prettier/prettier-vscode#3066)

But bad old require.resolve works.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for jade-cajeta-1bcca0 ready!

Name Link
🔨 Latest commit 90ff3ad
🔍 Latest deploy log https://app.netlify.com/sites/jade-cajeta-1bcca0/deploys/64e476baff62c60008973e47
😎 Deploy Preview https://deploy-preview-109--jade-cajeta-1bcca0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flying-sheep flying-sheep merged commit f2b87ee into main Aug 22, 2023
5 checks passed
@flying-sheep flying-sheep deleted the fix-pre-commit branch August 22, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant