-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support numpy 2.0 #2842
base: main
Are you sure you want to change the base?
feat: support numpy 2.0 #2842
Conversation
this is currently blocked by the following upstream dependencies not supporting numpy 2.0:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
- Coverage 85.22% 85.21% -0.01%
==========================================
Files 166 166
Lines 14229 14228 -1
==========================================
- Hits 12126 12125 -1
Misses 2103 2103
|
The last release of pymde was in 2022 and the last commit a year ago. I am not sure how sustainable it is to keep depending on it... |
Agreed seems like lowly maintained. I am then also against keeping it optional and we should just highlight it in some tutorial. With RAPIDS UMAP the need is also much smaller now. Loompy still doesn't support >2.0 based on a quick check though. So let's wait until they have figured things out and drop pyMDE then. |
@ori-kron-wis Can you switch loom to anndata.io (https://anndata.readthedocs.io/en/latest/generated/anndata.io.read_loom.html)? I assume we then support numpy>2.0. We should for now make pyMDE optional and set an optional requirement to numpy<2.0 for this dependency. We should drop it for the 1.3 release. |
closes #2390