-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MultiPolygons
in render_shapes()
#93
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 76.53% 78.19% +1.65%
==========================================
Files 10 10
Lines 1219 1284 +65
==========================================
+ Hits 933 1004 +71
+ Misses 286 280 -6
|
for more information, see https://pre-commit.ci
…erse/spatialdata-plot into feature/202306_support_multipolygons
this is quite nice, how's the coloring gonna work out? plot same color/annotation for all polygons in a multipolygon entry? |
Yeah, that was the idea. Didn't get to implementing that yet though |
Is it ready for review? (if not please mark the PR as draft). |
for more information, see https://pre-commit.ci
Reviewed at a high-level, looks good to me, great work! I let @Sonja-Stockhaus do a more in-depth review of the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Didn't notice anything odd and everything worked as it should when I ran it on my machine
Todo: