Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort parameter to points model #672

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

LucaMarconato
Copy link
Member

In spatialdata-io (e.g. in xenium()) we generally want the sort=True, here I enable this via a parameter.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (2e1347d) to head (a2aab25).

Files Patch % Lines
src/spatialdata/models/models.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   91.83%   91.82%   -0.02%     
==========================================
  Files          44       44              
  Lines        6776     6779       +3     
==========================================
+ Hits         6223     6225       +2     
- Misses        553      554       +1     
Files Coverage Δ
src/spatialdata/models/models.py 87.55% <87.50%> (-0.14%) ⬇️

@LucaMarconato
Copy link
Member Author

The test that fails is unrelated to this PR.

@LucaMarconato LucaMarconato merged commit cf16027 into main Aug 12, 2024
6 of 8 checks passed
@LucaMarconato LucaMarconato deleted the fix/points_model_sort_index branch August 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant