Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shortest_path parameter to get_transformation_between_coordinate_systems #714

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

quentinblampey
Copy link
Contributor

Related to issue #713, CC @LucaMarconato

Note that I changed the structure of the code, which was highly nested. The logic should be the same though
I also added some tests!

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (8879aff) to head (9e5f1e4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata/transformations/operations.py 94.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   91.84%   91.82%   -0.02%     
==========================================
  Files          44       44              
  Lines        6791     6802      +11     
==========================================
+ Hits         6237     6246       +9     
- Misses        554      556       +2     
Files with missing lines Coverage Δ
src/spatialdata/transformations/operations.py 88.83% <94.00%> (-0.91%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@LucaMarconato LucaMarconato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@LucaMarconato LucaMarconato enabled auto-merge (squash) September 26, 2024 16:27
@LucaMarconato LucaMarconato merged commit b9eb240 into scverse:main Sep 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants