Support multiple releases on graphs #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing leftover from debugging.
|
It's not visible that good as I have randomized test data. Note the graph legend on each graph, also there's point shape difference between releases. I left colors the same, but I'm not sure, maybe we should change hue or something to additionally differentiate. With filter on: |
k0machi
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Overall looks good, I do have some questions about frontend presentation - see comment about charts. One thing as well - looking at some of the graphs in production I can also see that uneven grid sometimes making it hard to read - is that a side effect of trying to line up the dates? Couldn't we set it up in a way that makes the grid uniform (don't have to have legend for each x value)?
k0machi
reviewed
Oct 23, 2024
soyacz
force-pushed
the
support-multiple-releases-on-graphs
branch
from
5f71bf9 to
37bc485
Compare
k0machi
approved these changes
Oct 24, 2024
Performance job can run against different scylla release. Because it was not taken into account, graph lines don't differentiate between them making impossible to distinguish different releases. This commit adds support for mixing different SUT releases in one job and make them visible as separate series on graphs. Additional 'releases' filters were added to easily toggle releases that should be shown. closes: scylladb#473
soyacz
force-pushed
the
support-multiple-releases-on-graphs
branch
from
37bc485 to
8bd2cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance job can run against different scylla release. Because it was
not taken into account, graph lines don't differentiate between them
making impossible to distinguish different releases.
This commit adds support for mixing different SUT releases in one job
and make them visible as separate series on graphs. Additional
'releases' filters were added to easily toggle releases that should be
shown.
closes: #473