Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(graphs-ux): graphs filters reorganization #495

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

soyacz
Copy link
Collaborator

@soyacz soyacz commented Oct 30, 2024

Some improvements around graphs filtering: less colors, more organization and labels.
image

@soyacz soyacz requested review from fruch and k0machi October 30, 2024 14:30
frontend/TestRun/ResultsGraphs.svelte Outdated Show resolved Hide resolved
frontend/TestRun/ResultsGraphs.svelte Outdated Show resolved Hide resolved
@fruch
Copy link
Contributor

fruch commented Oct 30, 2024

I think the table/column filter separation/titles is a bit unclear for the common user. what we mean by column here is, and what we mean by table, is not exactly intuitive

Maybe "group filters" and "metric filter" ? Or something in that direction?

Also it would be really helpful to have tooltips with a longer description for each button we show there

Some improvements around graphs filtering: less colors, more
organization and labels.
@soyacz soyacz force-pushed the improve-ux-around-filters branch from e12f9d1 to b10f5dd Compare October 31, 2024 13:32
@soyacz
Copy link
Collaborator Author

soyacz commented Oct 31, 2024

I think the table/column filter separation/titles is a bit unclear for the common user. what we mean by column here is, and what we mean by table, is not exactly intuitive

Maybe "group filters" and "metric filter" ? Or something in that direction?

I replaced with just Filters and Metrics - after clicking it should become more intuitive.

Also it would be really helpful to have tooltips with a longer description for each button we show there

I validated idea and it doesn't play well with filters. E.g. descriptions: for read - _mgmt_repair_cli - stalls - REACTOR_STALLED is REACTOR_STALLED event counts or table read - _mgmt_repair_cli - latencies has read workload - Scylla-Manger repair.
I'd rather see descriptions in graphs itself, under the titles.

@soyacz
Copy link
Collaborator Author

soyacz commented Oct 31, 2024

image

@fruch
Copy link
Contributor

fruch commented Nov 3, 2024

I think the table/column filter separation/titles is a bit unclear for the common user. what we mean by column here is, and what we mean by table, is not exactly intuitive
Maybe "group filters" and "metric filter" ? Or something in that direction?

I replaced with just Filters and Metrics - after clicking it should become more intuitive.

Much better

Also it would be really helpful to have tooltips with a longer description for each button we show there

I validated idea and it doesn't play well with filters. E.g. descriptions: for read - _mgmt_repair_cli - stalls - REACTOR_STALLED is REACTOR_STALLED event counts or table read - _mgmt_repair_cli - latencies has read workload - Scylla-Manger repair. I'd rather see descriptions in graphs itself, under the titles.

Logicly I would argue that it's best to be visible when you are selecting what to look at.
and not after browsing all of the graphs.
nevertheless, we should be able to see those descriptions for anything that has a description.

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soyacz
Copy link
Collaborator Author

soyacz commented Nov 4, 2024

Logicly I would argue that it's best to be visible when you are selecting what to look at. and not after browsing all of the graphs. nevertheless, we should be able to see those descriptions for anything that has a description.

#496

@soyacz soyacz merged commit 59e4beb into scylladb:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants