fix(summary-widget): sort tests #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scrolling Scylla versions in summary widget, tests are appearing in random order. Sort it by test name.
fruch
reviewed
Dec 23, 2024
|
|
||
| const sortedEntries = Object.entries(data).sort(([, a], [, b]) => { | ||
| if (a.name && b.name) { | ||
| return a.name.localeCompare(b.name); |
There was a problem hiding this comment.
nice, I can write test names in hebrew :)
There was a problem hiding this comment.
currently it takes mostly from build_id - I didn't see yet any test_name to be specified in sct_test_run table...
You need use hebrew in jenkins thou 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrolling Scylla versions in summary widget, tests are appearing in random order. Sort it by test name.