Implement cass_retry_policy_logging_new and enable some exec profile integration tests
#287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the next commits, I'll want to import RetryPolicy from rust-driver. 1. We don't want to have a name clashes 2. We already have a convention of prefixing public types with Cass. Bonus: I also removed the global variant imports.
It's used in some tests.
It was commented out, because `cass_retry_policy_logging_new` was not implemented.
1. This test entry was placed after "-" sign. The tests after this are excluded (explicitly disabled). 2. The syntax for test filter was just wrong. "ExecutionProfileTest.InvalidName" did not pick up anything.
muzarski
added
the
P2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #260
Ref: #132
Pre-review checklist
.github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.