integration: increase timestamp tolerance in Timestamps test #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Timestamps test in the integration suite was failing due to the timestamp difference being bigger than the tolerated threshold. Git blame reveals that the threshold was alread increased from 100ms to 150ms by Gor in 2022. I assume 500 ms will be enough for now. A question aside is whether this test comparison gives us any benefit at all. It seems to be a flaky test that is not very useful. Perhaps we should consider just removing this flaky timing-based check.
Lorak-mmk
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Timestamps test in the integration suite was failing due to the timestamp difference being bigger than the tolerated threshold. Git blame reveals that the threshold was alread increased from 100ms to 150ms by Gor in 2022. I assume 500 ms will be enough for now.
A question aside is whether this test comparison gives us any benefit at all. It seems to be a flaky test that is not very useful. Perhaps we should consider just removing this flaky timing-based check.
Fixes: #312
Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.