Add setting connected_event flag in libevreactor
#292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
LGTM, you should add the description of PR to the commit message and you should add that other reactors have the same self.error_all_requests(ConnectionShutdown(...)) logic, but they have self.connected_event.set() after that, so it was probably an oversight (copy-paste mistake?) that it was missing from this reactor.
Before, the connected_event flag was set in every implementation of Connection but this utilizing libev. Other reactors have the same `self.error_all_requests(ConnectionShutdown(...))` logic, but they have `self.connected_event.set()` after that, so it was probably an oversight (copy-paste mistake?) that it was missing from this reactor. That was causing the driver to sometimes hang for >3 minutes when shutting down. This commit adds setting the `connected_event` flag in `close()` in `LibevConnection`.
sylwiaszunejko
force-pushed
the
debug_driver_hanging
branch
from
df315f4 to
7982b71
Compare
|
I updated the commit message |
Lorak-mmk
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the
connected_eventflag was set in every implementation ofConnectionbut this utilizinglibev. That was causing the driver to sometimes hang for >3 minutes when shutting down.This PR adds setting the connected_event flag in
close()inLibevConnection.Fixes: #172