fix(BaseNode): fix is_enterprise property for 2025.1 #10008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pehala
previously approved these changes
Feb 6, 2025
Lakshmipathi
previously approved these changes
Feb 6, 2025
How "> 6.3" will include all 202x.x versions? |
2000 is greater than 6 - first major versions are compared |
roydahan
previously approved these changes
Feb 6, 2025
soyacz
dismissed stale reviews from roydahan, Lakshmipathi, and pehala
via
2b237bb
soyacz
force-pushed
the
fix-is-enterprise-prop-in-base-node
branch
3 times, most recently
from
458fcc8 to
d809953
Compare
We use available package to determine if is enterprise product. With 2025.1 being not enterprise package it no longer works as expected. Fix by additional comparison of available pkg version for 'scylla' package - all versions above 6.3 are counted as enterprise: this includes all 202x.x versions.
soyacz
force-pushed
the
fix-is-enterprise-prop-in-base-node
branch
from
d809953 to
5505cf9
Compare
pehala
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to verify installed package if is enterprise to determine product.
With 2025.1 being not enterprise package it no longer works as expected.
Fix by comparing scylla version to 6.3 - all versions above are counted as enterprise: this includes all 202x.x versions.
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)