-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(sct_config): appendable configuration values #9554
Conversation
88a2fa0
to
8338361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should somehow document it.
Maybe configuration_options.md
could have few remarks before options table stating that e.g dicts are merged, or str/lists can be appended like that?
all strings configuration can be used like that, and everything with the |
#9558 should make that doc a bit more usable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we're going to document it in followup - LGTM
8338361
to
28a1a94
Compare
now with the docs update, that would specific which one can be appended and which one can not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the code that verifies 'appendable' - shouldn't it be added and fail fast?
a41bf58
to
747658d
Compare
introduce new option for appending to string or list configuration values 1) strings: can be appended with adding `++` at the begining of the string: `export SCT_APPEND_SCYLLA_ARGS="++ --overprovisioned 1"` 2) list: can be appended by adding `++` as the first item of the list `export SCT_SCYLLA_D_OVERRIDES_FILES='["++", "extra_file/scylla.d/io.conf"]'` Note list would work on every config defiend with `str_or_list_or_eval` with the expection of `config_files`, `region_name`, `gce_datacenter` and `gce_datacenter` which can't be appended, and would need to be overriden completly Ref: scylladb#7653
747658d
to
e852d25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
introduce new option for appending to string or list configuration values
strings: can be appended with adding
++
at the begining of the string:export SCT_APPEND_SCYLLA_ARGS="++ --overprovisioned 1"
list: can be appended by adding
++
as the first item of the listexport SCT_SCYLLA_D_OVERRIDES_FILES='["++", "extra_file/scylla.d/io.conf"]'
Note list would work on every config defiend with
str_or_list_or_eval
with the expection ofconfig_files
,region_name
,gce_datacenter
andgce_datacenter
which can't be appended, and would need to be overriden completlyRef: #7653
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)