[Backport 2024.1] fix(sstables_validator): fix upload sstables #9907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error message changed for scrub validation and upload sstables in validator stopped working. Still event handler catched that and uploaded - but actually should not when scrub validator sends them. Fix by adjusting to error line (should be more elastic) and adjusted event handler to not send corrupted sstables in context of sstables validator. Added sstable util to corrupt sstable (just for testing this and possibly may be used in other contexts). fixes: scylladb#9854 (cherry picked from commit f64203d)
|
@soyacz - This PR has conflicts, therefore it was moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message changed for scrub validation and upload sstables in validator stopped working. Still event handler catched that and uploaded
Fix by adjusting to error line (should be more elastic) and adjusted event handler to not send corrupted sstables in context of sstables validator.
Added sstable util to corrupt sstable (just for testing this and possibly may be used in other contexts).
fixes: #9854
Testing
PR pre-checks (self review)
backportlabelsReminders
Add New configuration option and document them (in
sdcm/sct_config.py)Add unit tests to cover my changes (under
unit-test/folder)Update the Readme/doc folder relevant to this change (if needed)
(cherry picked from commit f64203d)
Parent PR: #9900