Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove Makefile k8s source #598

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

yaronkaikov
Copy link
Collaborator

As the code is no longer in use

@yaronkaikov yaronkaikov requested a review from fruch January 9, 2025 08:48
@yaronkaikov yaronkaikov changed the title cleanup: remove k8s content cleanup: remove Makefile k8s source and tools Jan 9, 2025
@yaronkaikov yaronkaikov force-pushed the cleancode branch 2 times, most recently from ec2520d to b1083e8 Compare January 9, 2025 09:00
@yaronkaikov yaronkaikov changed the title cleanup: remove Makefile k8s source and tools cleanup: remove Makefile k8s source Jan 9, 2025
As the code is no longer in use
@yaronkaikov
Copy link
Collaborator Author

@Annamikhlin @fruch please review

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that exists somewhere else ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. you don't think this repo need a documentation of it's own ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use it, why do we need it here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you know where the docs are and how to update them

@yaronkaikov yaronkaikov requested a review from fruch January 26, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants