Add a fix for #4017 into the 3.4.1 release #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commits a75df89 and 3cdd20d added and started setting new labels (dc/rack) to the healthcheck metrics. Unfortunately, those labels weren't taken into consideration when removing labels of removed clusters/nodes. This resulted in not removing those metrics until SM restart. This commit fixes this issue and brings a small refactor to the way in which healthcheck labels are applied, so that it's more difficult to make such mistake in the future. Fixes #4017 (cherry picked from commit a16e511)
|
@karol-kokoszka the only failure is the known and reported flake #4172. |
karol-kokoszka
approved these changes
Dec 18, 2024
|
Operator tests passed: scylladb/scylla-operator#2286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fix for #4017 into the 3.4.1 release.