Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic OpenShift support and setup [Part 1] #1955

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Add basic OpenShift support and setup [Part 1] #1955

merged 5 commits into from
Dec 31, 2024

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Jun 5, 2024 •
edited
Loading

Description of your changes:
This PR brings the initial support for running on OpenShift.

It also fixes the operator when run on platforms where OwnerReferencesPermissionEnforcement is enabled.

It also moves all persistent storage to /var/lib which is available on all OSes, including atomic ones / CoreOS.

Note: This is part 1 that wires everything together and fixes most of the issues. Some tests that fail only on OpenShift still fail and need individual followups and we also needs to wire in proper cpu limits that flake a lot of tests waiting for certs to be generated.

Which issue is resolved by this Pull Request:
Resolves #713 #1935

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 5, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: GitHub didn't allow me to request PR reviews from the following users: tnozicka.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes:
TODO

Which issue is resolved by this Pull Request:
Resolves #713 #1935

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@tnozicka tnozicka force-pushed the fix-openshift branch 2 times, most recently from 0afcbff to 3b42f12 Compare June 14, 2024 10:09
@tnozicka tnozicka marked this pull request as draft June 14, 2024 11:14
@scylla-operator-bot scylla-operator-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2024
@tnozicka tnozicka force-pushed the fix-openshift branch 3 times, most recently from a9522f7 to 3fd195c Compare June 28, 2024 12:45
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@scylla-operator-bot scylla-operator-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2024
@tnozicka tnozicka force-pushed the fix-openshift branch 3 times, most recently from 75a8f53 to 8513810 Compare July 26, 2024 14:57
@tnozicka tnozicka marked this pull request as ready for review August 7, 2024 11:43
@tnozicka tnozicka force-pushed the fix-openshift branch 2 times, most recently from 0a08384 to 1475312 Compare August 9, 2024 09:09
rzetelskik
rzetelskik reviewed Aug 9, 2024
View reviewed changes
hack/ci-deploy.sh Outdated Show resolved Hide resolved
@scylladb scylladb deleted a comment from scylla-operator-bot bot Aug 9, 2024
@scylladb scylladb deleted a comment from scylla-operator-bot bot Aug 9, 2024
@tnozicka tnozicka force-pushed the fix-openshift branch 2 times, most recently from 5800971 to 169c28a Compare December 27, 2024 15:12
@tnozicka tnozicka changed the title [WIP] Fix OpenShift [Part 1] Fix OpenShift [Part 1] Dec 27, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2024
@tnozicka
Copy link
Member Author

/test e2e-openshift-aws-parallel
/test e2e-openshift-aws-serial
(out of interest, but expected to fail on some)

@rzetelskik
Copy link
Member

Also please make the PR title a bit more descriptive

@tnozicka tnozicka changed the title Fix OpenShift [Part 1] Add basic OpenShift support [Part 1] Dec 27, 2024
@tnozicka tnozicka changed the title Add basic OpenShift support [Part 1] Add basic OpenShift support and setup[Part 1] Dec 27, 2024
@tnozicka tnozicka changed the title Add basic OpenShift support and setup[Part 1] Add basic OpenShift support and setup [Part 1] Dec 27, 2024
@tnozicka tnozicka mentioned this pull request Dec 27, 2024
Open
@tnozicka
Copy link
Member Author

/test e2e-openshift-aws-serial
(cluster provisioning failed)

@tnozicka
Copy link
Member Author

/retest
e2e-gke-release-script-latest should be unborked now

@tnozicka
Copy link
Member Author

tnozicka commented Dec 27, 2024 •
edited
Loading

/test e2e-openshift-aws-parallel
/test e2e-openshift-aws-serial
(for reference - some of the failures are races / easy wins for the next PR)

@tnozicka
Copy link
Member Author

ci/prow/e2e-gke-release-script-latest

this has to fail because it deploys local-csi-driver from a released image and we have changed the mount paths

https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1955/pull-scylla-operator-master-e2e-gke-release-script-latest/1872752453217161216#1:test-build-log.txt%3A287

note: 'MountVolume.SetUp failed for volume "volumes-dir" : hostPath type check failed:
  /mnt/persistent-volumes is not a directory'

https://gcsweb.scylla-operator.scylladb.com/gcs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1955/pull-scylla-operator-master-e2e-gke-release-script-latest/1872752453217161216/artifacts/must-gather/0/namespaces/local-csi-driver/events.events.k8s.io/local-csi-driver-jtsx9.1815258d6c62fdda.yaml

/override ci/prow/e2e-gke-release-script-latest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-release-script-latest

In response to this:

ci/prow/e2e-gke-release-script-latest

this has to fail because it deploys local-csi-driver from a released image and we have changed the mount paths

https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1955/pull-scylla-operator-master-e2e-gke-release-script-latest/1872752453217161216#1:test-build-log.txt%3A287

note: 'MountVolume.SetUp failed for volume "volumes-dir" : hostPath type check failed:
 /mnt/persistent-volumes is not a directory'

https://gcsweb.scylla-operator.scylladb.com/gcs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1955/pull-scylla-operator-master-e2e-gke-release-script-latest/1872752453217161216/artifacts/must-gather/0/namespaces/local-csi-driver/events.events.k8s.io/local-csi-driver-jtsx9.1815258d6c62fdda.yaml

/override ci/prow/e2e-gke-release-script-latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tnozicka tnozicka requested a review from rzetelskik December 27, 2024 21:52
@rzetelskik
Copy link
Member

(one outstanding comment)

@tnozicka
Copy link
Member Author

tnozicka commented Dec 30, 2024 •
edited
Loading

(one outstanding comment)

explained in #1955 (comment)
hopefully we can land it as the first step and iterate on this

@rzetelskik
Copy link
Member

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2024
@tnozicka
Copy link
Member Author

#2285 (comment)
/retest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Dec 30, 2024 •
edited
Loading

@tnozicka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-aws-serial f0db302 link false /test e2e-openshift-aws-serial
ci/prow/e2e-openshift-aws-parallel f0db302 link false /test e2e-openshift-aws-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@scylla-operator-bot scylla-operator-bot bot merged commit 1061639 into scylladb:master Dec 31, 2024
15 of 17 checks passed
@tnozicka tnozicka deleted the fix-openshift branch December 31, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@rzetelskik rzetelskik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScyllaDB installation on openshift
3 participants
@tnozicka @adarshaj @rzetelskik