Update contribution guide

[zimnx]

Our contribution guide is very outdated and recommends style we don't use anymore. Content was updated to follow our existing style and lays out a coding convention and code review standard.

[scylla-operator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zimnx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rzetelskik]

Leaving some suggestions for changes in wording, take the ones addressing style and conciseness rather than substance as mostly optional. I'm yet to look at the proposed guides

[tnozicka]

I am yet to go through the referenced documents, but I'd personally not couple fixing the existing practices and introducing new rules.

[scylla-operator-bot]

The Scylla Operator project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 30d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out

/lifecycle stale

[zimnx]

/remove-lifecycle stale

[rzetelskik]

We should speed this one up, we don't have any contribution guide atm, and we also need to remove/update the references: #2291 (comment). Perhaps we could just add this as CONTRIBUTING.md at the top level?

[scylla-operator-bot]

@zimnx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gke-multi-datacenter-parallel	bd7b9e2	link	true	/test e2e-gke-multi-datacenter-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mflendrich]

/cc rzetelskik zimnx

[scylla-operator-bot]

@mflendrich: GitHub didn't allow me to request PR reviews from the following users: zimnx.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc rzetelskik zimnx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rzetelskik]

@mflendrich please try to keep the commits squashed (we try to avoid changes to the same file in multiple commits)
We also leave conversation resolution to the reviewers, otherwise it's hard to track if they were addressed

[mflendrich]

Please review again.

A style guide is one of those things that can easily produce diminishing returns work. Let's get one in place and then tackle individual improvements in targetted, narrow, easy to review PRs.

One such improvement I'd definitely like to see is cutting the length at least by 50%. But let's pick our battles for now.

[rzetelskik]

A style guide is one of those things that can easily produce diminishing returns work. Let's get one in place and then tackle individual improvements in targetted, narrow, easy to review PRs.

While I agree with the sentiment, this usually leads to just never getting back to it.
There is one unaddressed comment remaining, rest lgtm.

[mflendrich]

Thanks @rzetelskik. PTAL now ☝️ 🙇

[rzetelskik]

thanks, lgtm
/assign zimnx

[zimnx]

lgtm

[rzetelskik]

/lgtm