tests/unit: Fix exception verification in json2code_test.py #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, exception verification code was placed after the function call
within assertRaises(), making it unreachable. This caused the test to
pass without actually verifying the exception details.
Move the verification code outside the assertRaises() block by capturing
the exception first. This ensures the test properly validates both the
exception type and its attributes.
Example:
Before:
```py
with self.assertRaises(ValueError):
function_call()
self.assertEqual(exc.message, "expected message") # Never executed
```
After:
```py
with self.assertRaises(ValueError) as e:
function_call()
self.assertEqual(e.exception.message, "expected message") # Executed
```
Signed-off-by: Kefu Chai <[email protected]>
Replace hardcoded HTTP status code 404 with http.HTTPStatus.NOT_FOUND to improve code readability and maintainability. Using symbolic constants makes the test's intent clearer and helps prevent typos. Before: self.assertEqual(response.status_code, 404) After: self.assertEqual(response.status_code, http.HTTPStatus.NOT_FOUND) Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, exception verification code was placed after the function call
within assertRaises(), making it unreachable. This caused the test to
pass without actually verifying the exception details.
Move the verification code outside the assertRaises() block by capturing
the exception first. This ensures the test properly validates both the
exception type and its attributes.
Example:
Before:
After: