correct span request

sdcb · Dec 24, 2024 · 989c9fc · 989c9fc
1 parent 062f72b
commit 989c9fc
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/BE/Controllers/Chats/Chats/ChatController.cs b/src/BE/Controllers/Chats/Chats/ChatController.cs
@@ -98,6 +98,20 @@ public async Task<IActionResult> GeneralChat(
             return BadRequest(ModelState);
         }
 
+        if (req.SpanIds.Length == 0)
+        {
+            return BadRequest("Spans must be provided");
+        }
+
+        foreach (int spanId in req.SpanIds)
+        {
+            if (spanId >= byte.MinValue && spanId <= byte.MaxValue)
+            {
+                continue;
+            }
+            return BadRequest("Invalid span id");
+        }
+
         // ensure request span id is unique
         if (req.SpanIds.Distinct().Count() != req.SpanIds.Length)
         {

diff --git a/src/BE/Controllers/Chats/Chats/Dtos/FreshChatRequest.cs b/src/BE/Controllers/Chats/Chats/Dtos/FreshChatRequest.cs
@@ -66,7 +66,7 @@ public override ChatRequest ToChatRequest()
 public record GeneralChatRequest : BaseChatRequest
 {
     [JsonPropertyName("spanIds")]
-    public required byte[] SpanIds { get; init; }
+    public required int[] SpanIds { get; init; }
 
     [JsonPropertyName("userMessage")]
     public required MessageContentRequest UserMessage { get; init; }
@@ -80,7 +80,7 @@ public override ChatRequest ToChatRequest()
         {
             EncryptedChatId = EncryptedChatId,
             EncryptedMessageId = ParentAssistantMessageId,
-            Spans = SpanIds.Select(x => new InternalChatSpanRequest() { Id = x }).ToArray(),
+            Spans = SpanIds.Select(x => new InternalChatSpanRequest() { Id = (byte)x }).ToArray(),
             UserMessage = UserMessage
         };
     }