Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve score feed performance #1

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

sdenis29
Copy link
Owner

@sdenis29 sdenis29 commented Sep 9, 2022

Fixes: issue url

Changes

Fixed n+1 queries problem using eager loading instead of lazy loading by adding includes(:user) in user_feed method which fetch the users associated with their scores in one query.

Before

Screenshot 2022-09-09 at 15 06 56

After

Screenshot 2022-09-09 at 15 09 05

@SergiuApostuTOL
Copy link
Collaborator

When specifying the issue url, just paste the raw url in there without renaming it and Github will handle the rest, like AACraiu#1

@sdenis29 sdenis29 changed the base branch from main to develop September 13, 2022 08:43
@SergiuApostuTOL
Copy link
Collaborator

This is a hotfix branch, its target should be indeed main.

@sdenis29 sdenis29 changed the base branch from develop to main September 13, 2022 11:18
@SergiuApostuTOL SergiuApostuTOL merged commit be5eed5 into main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve scores feed performance
2 participants